8000 #11228 -gem secrets generator by pbmoses · Pull Request #11229 · grafana/mimir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#11228 -gem secrets generator #11229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

#11228 -gem secrets generator #11229

wants to merge 6 commits into from

Conversation

pbmoses
Copy link
Member
@pbmoses pbmoses commented Apr 15, 2025

What this PR does

addresses #11228

Which issue(s) this PR fixes or relates to

#11228

Fixes #11228

Checklist

external tool, CHANGELOG NA.

pbmoses added 2 commits April 15, 2025 08:48
initial commit of gem-secrets-generator
@pbmoses
Create READEME.md
f726d60 
initial README
@pbmoses pbmoses requested a review from a team as a code owner April 15, 2025 16:26
@CLAassistant
Copy link
CLAassistant commented Apr 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

pbmoses added 4 commits April 15, 2025 15:35
@pbmoses
Update gem-secrets-generator.go
f383b0f 
gci formattting
@pbmoses
Update gem-secrets-generator.go
c4e4b4f 
gci formatting
@pbmoses
Update gem-secrets-generator.go
a459096 
GCI issues Grafana formatting
@pbmoses
Update gem-secrets-generator.go
c50e907 
another gci change :(
dimitarvdimitrov
dimitarvdimitrov reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor
@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't kubectl already do this? for example

kubectl create secret generic --dry-run=client --from-literal=a=b my-secret -oyaml
apiVersion: v1
data:
  a: Yg==
kind: Secret
metadata:
  creationTimestamp: null
  name: my-secret

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitarvdimitrov dimitarvdimitrov dimitarvdimitrov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: Provide tooling to create secrets that are required for GEM install
3 participants
@pbmoses @CLAassistant @dimitarvdimitrov
0