8000 Switch k6 packager to Vault by inancgumus · Pull Request #4833 · grafana/k6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch k6 packager to Vault #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 17, 2025
Merged

Switch k6 packager to Vault #4833

merged 8 commits into from
Jun 17, 2025

Conversation

inancgumus
Copy link
Contributor
@inancgumus inancgumus commented Jun 5, 2025 •
edited
Loading

What?

Retrieves secrets from Vault and adjusts the k6packager deployment process.

Passing builds:

See grafana/k6-cloud#3483 for more details.

Why?

For stronger security.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.

Related PR(s)/Issue(s)

  • grafana/k6-cloud#3483

@inancgumus inancgumus force-pushed the aws-deploy branch 16 times, most recently from 9fbc679 to b819e9b Compare June 9, 2025 22:38
@inancgumus inancgumus changed the title aws deploy experiments Switch k6 packager to Vault Jun 9, 2025
@inancgumus inancgumus self-assigned this Jun 9, 2025
@inancgumus inancgumus added the ci label Jun 9, 2025
@inancgumus inancgumus force-pushed the aws-deploy branch 2 times, most recently from efe7995 to 7148217 Compare June 10, 2025 13:53
codebien
codebien reviewed Jun 10, 2025
View reviewed changes
@inancgumus inancgumus force-pushed the aws-deploy branch 8 times, most recently from accbacc to e9e066a Compare June 11, 2025 00:28
@grafana grafana locked and limited conversation to collaborators Jun 12, 2025
@grafana grafana unlocked this conversation Jun 12, 2025
@inancgumus inancgumus force-pushed the aws-deploy branch 4 times, most recently from 7d8bf7e to 51c0257 Compare June 13, 2025 18:34
@inancgumus inancgumus added this to the v1.1.0 milestone Jun 13, 2025
@inancgumus inancgumus marked this pull request as ready for review June 13, 2025 19:15
@inancgumus inancgumus requested a review from a team as a code owner June 13, 2025 19:15
@inancgumus inancgumus requested review from ankur22, codebien and Copilot and removed request for a team June 13, 2025 19:15
Copilot

This comment was marked as resolved.

Sign in to view

@inancgumus
Prevent k6 packager s3cmd to set ACLs
bdb8042 
We manage these ourselves as per Amazon recommendations for security.
@inancgumus inancgumus requested a review from joanlopez June 14, 2025 01:55