8000 Golangci-lint v2 update by mstoykov · Pull Request #4744 · grafana/k6 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Golangci-lint v2 update #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 8, 2025
Merged

Golangci-lint v2 update #4744

merged 8 commits into from
May 8, 2025

Conversation

mstoykov
Copy link
Contributor
@mstoykov mstoykov commented Apr 25, 2025 •
edited
Loading

What?

Update golangci-lint to v2.

This also required a bunch of fixes. I have tried to keep the changes to minimum and separated in commits that are easier to review.

Why?

It has been out for a while, so we probably should move over to it.

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@mstoykov mstoykov changed the title Golangci update Golangci-lint v2 update Apr 25, 2025
@mstoykov mstoykov marked this pull request as ready for review April 25, 2025 08:21
@mstoykov mstoykov requested a review from a team as a code owner April 25, 2025 08:21
@mstoykov mstoykov requested review from inancgumus and oleiade and removed request for a team April 25, 2025 08:21
inancgumus
inancgumus previously approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member
@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

oleiade
oleiade previously approved these changes Apr 29, 2025
View reviewed changes
@mstoykov mstoykov added this to the v1.1.0 milestone Apr 30, 2025
@mstoykov mstoykov dismissed stale reviews from inancgumus and oleiade via 722b50a May 7, 2025 14:00
@mstoykov mstoykov requested review from inancgumus and oleiade May 7, 2025 14:10
@mstoykov mstoykov requested a review from codebien May 7, 2025 14:10
@mstoykov mstoykov merged commit d62140b into master May 8, 2025
33 checks passed
@mstoykov mstoykov deleted the golangciUpdate branch May 8, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@codebien codebien codebien approved these changes

@oleiade oleiade Awaiting requested review from oleiade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mstoykov @inancgumus @oleiade @codebien
0