Secret source fixes #4621
Merged
Secret source fixes #4621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
previously approved these changes
Mar 11, 2025
4d15f04 to
b7ae0dc
Compare
d0ugal
added a commit
to grafana/gsm-api-go-client
that referenced
this pull request
Mar 12, 2025
go get go.k6.io/k6@secretSourceFixes This inclues a number of small fixes for secret source. grafana/k6#4621
d0ugal
added a commit
to grafana/gsm-api-go-client
that referenced
this pull request
Mar 12, 2025
go get go.k6.io/k6@secretSourceFixes This includes a number of small fixes for secret source. grafana/k6#4621
inancgumus
approved these changes
Mar 12, 2025
joanlopez
approved these changes
Mar 13, 2025
d0ugal
added a commit
to grafana/gsm-api-go-client
that referenced
this pull request
Mar 13, 2025
go get go.k6.io/k6@70df5caa068d89bee752eaf0a00ed61918eea37b This includes a number of small fixes for secret source. grafana/k6#4621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
69A9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Some small fixes to the newly merged secret source
Why?
A missed thing to be updated and some documentation for extension developers.
Reviewing by commit is likely going to be easier, but it isn't that big to begin with.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)