8000 Allow periods in route heuristics by marevers · Pull Request #1858 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow periods in route heuristics #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Allow periods in route heuristics #1858

merged 1 commit into from
Apr 25, 2025

Conversation

marevers
Copy link
Collaborator

Closes #1849

Allows periods in the route path heuristics so that RPC style path components are no longer replaced by the wildcard character.

@marevers marevers requested a review from a team as a code owner April 25, 2025 06:49
@codecov Codecov
Copy link
codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.89%. Comparing base (24d2e4f) to head (0658d1e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
- Coverage   74.20%   73.89%   -0.32%     
==========================================
  Files         177      177              
  Lines       19232    19232              
==========================================
- Hits        14272    14211      -61     
- Misses       4227     4289      +62     
+ Partials      733      732       -1
Flag Coverage Δ
integration-test 57.63% <100.00%> (+0.38%) ⬆️
k8s-integration-test 55.68% <100.00%> (+0.05%) ⬆️
oats-test 35.28% <100.00%> (-0.25%) ⬇️
unittests 46.06% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mariomac
mariomac approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for the fix

@mariomac mariomac added bug port-to-otel-ebpf-inst PRs that need to be ported to otel-ebpf-instrumentation labels Apr 25, 2025
grcevski
grcevski approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@grcevski grcevski merged commit 973b7e8 into grafana:main Apr 25, 2025
15 checks passed
@marevers marevers deleted the rpc-heuristics branch April 28, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariomac mariomac mariomac approved these changes

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
bug port-to-otel-ebpf-inst PRs that need to be ported to otel-ebpf-instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPC-style API endpoints in Beyla metrics
3 participants
@marevers @mariomac @grcevski
0