8000 Remove memset in favour of direct byte write by rafaelroquetto · Pull Request #1832 · grafana/beyla · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove memset in favour of direct byte write #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Remove memset in favour of direct byte write #1832

merged 2 commits into from
Apr 15, 2025

Conversation

rafaelroquetto
Copy link
Contributor

Revert code as the verifier seems happy now.

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner April 14, 2025 20:24
@codecov Codecov
Copy link
codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.78%. Comparing base (3ec71b5) to head (467471f).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1832      +/-   ##
==========================================
+ Coverage   64.33%   67.78%   +3.44%     
==========================================
  Files         225      225              
  Lines       22966    22966              
==========================================
+ Hits        14776    15568     +792     
+ Misses       7412     6611     -801     
- Partials      778      787       +9
Flag Coverage Δ
integration-test 55.05% <ø> (-0.10%) ⬇️
k8s-integration-test 53.39% <ø> (?)
oats-test 34.98% <ø> (ø)
unittests 43.76% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rafaelroquetto rafaelroquetto changed the title Memset restore Remove memset in favour of direct byte write Apr 14, 2025
grcevski
grcevski approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor
@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rafaelroquetto rafaelroquetto merged commit 4373fed into main Apr 15, 2025
14 checks passed
@rafaelroquetto rafaelroquetto deleted the memset_restore branch April 15, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grcevski grcevski grcevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelroquetto @grcevski
0