fix: change ThresholdStep type from int to float64 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @grafov I see you're a top contributor - do you mind giving this a quick look? |
|
@GiedriusS could you take a look at this? |
|
Here's where the threshold datatype is defined on the grafana side https://github.com/grafana/grafana/blob/277a83215c1e20ff8c93768f93edf92d60deee5f/packages/grafana-data/src/types/thresholds.ts#L2 |
|
Ah it seems that another PR already fixed this. Now the only thing my PR does is just add a test. |
GiedriusS
approved these changes
Jun 11, 2022
ripta
pushed a commit
to ZipRecruiter/grafana-tools-sdk
that referenced
this pull request
Jul 23, 2022
(cherry picked from commit 5c2631a)
wurbanski
pushed a commit
to kubermatic/grafanasdk
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thresholds can also be floats.
Also adds a generic test with a timeseries panel since we didn't have one before with float and int thresholds.