Pipeline error for out of bounds array with dynamic and offset #4384

petermcneeleychromium · 2025-05-05T17:13:57Z

Const indices are validated against array types for bounds checking even if there is a dynamic index dependency on the array expression.

For example

const q = array(array(14,2,3),array(1,7,3));

const o = 17;
fn compute() -> f32 {
  var a = 20;
  return f32(q[a][o]);
}

Will generate an out of bounds error (compile)
whereas currently we expect (but do not get) a pipeline error for


const q = array(array(14,2,3),array(1,7,3));

const o = 17;
fn compute() -> f32 {
  var a = 20;
  return f32(q[a][o]);
}

crbug.com/415298444

jrprice · 2025-05-05T18:24:31Z

src/webgpu/shader/validation/expression/access/array.spec.ts

@@ -378,6 +378,45 @@ const kOutOfBoundsCases: Record<string, OutOfBoundsCase> = {
    pipeline: true,
    value: 1,
  },
+  override_array_dynamic_tested_oob_pos: {


What does "tested" signify in these case names?

tested is pretty vague. It should be type checked. As it is the type itself that has bounds.

Pipeline error for out of bounds array with dynamic and offset

2df39cd

petermcneeleychromium requested a review from jrprice May 5, 2025 17:19

jrprice approved these changes May 5, 2025

View reviewed changes

change 'tested' to 'type_checked'

00a46fc

petermcneeleychromium merged commit e5e17d8 into gpuweb:main May 5, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pipeline error for out of bounds array with dynamic and offset #4384

Pipeline error for out of bounds array with dynamic and offset #4384

Pipeline error for out of bounds array with dynamic and offset #4384

Pipeline error for out of bounds array with dynamic and offset #4384

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment