8000 If BC is supported, BC Sliced 3D must be supported by beaufortfrancois · Pull Request #4379 · gpuweb/cts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

If BC is supported, BC Sliced 3D must be supported #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

If BC is supported, BC Sliced 3D must be supported #4379

merged 2 commits into from
May 2, 2025

Conversation

beaufortfrancois
Copy link
Collaborator
@beaufortfrancois beaufortfrancois commented May 2, 2025 •
edited by kainino0x
Loading

Spec PR: gpuweb/gpuweb#5184

Issue:

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@beaufortfrancois beaufortfrancois requested a review from kainino0x May 2, 2025 07:30
@beaufortfrancois
Copy link
Collaborator Author

FYI @mehmetoguzderin

@kainino0x kainino0x enabled auto-merge (squash) May 2, 2025 22:28
@kainino0x kainino0x merged commit f42b4e6 into main May 2, 2025
1 check passed
@kainino0x kainino0x deleted the fix-bc branch May 2, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kainino0x kainino0x kainino0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beaufortfrancois @kainino0x
0