[go1.19] Updating more natives for go1.19 #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevkontakte
approved these changes
Jan 31, 2024
|
@nevkontakte Thank you so much for all your help. Yeah, getting CI passing really helped and will make this work go faster. I'm going to continue working on this effort as needed and help GopherJS continue towards go1.21 (or go1.22) as much as you need and I can. I got Workiva to run the go1.19 branch on several of their (our since I work for them too) repos to see if the unit-tests for their specific code passes. They will not update to go1.19 until it is in master, this is just a "use case test" of the changes we've been making. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating more natives for go1.19 without generics:
crypto: It had a copy/paste issue and had to remove the cache. The cache hooks into the GC to clear periodically. I wasn't sure if there was a JS equivalent or if we wanted to use a timer, so I just removed the cache, and now it is treated as if it was always a cache miss.debug/pe: It had some unsafe pointers for casting one struct into another struct's memory footprint.go/token/position: Was getting issues with finding most recent file so changed the fix to use*Filedirectly.hash/maphash: It had parts from go1.16 which could be updated to match closer to go1.19. It had some new methods,BytesandString, that were using unsafe pointer.reflectandreflectlite: It has some minor changes with some notable changes toCapandLento allow for pointers to arrays and tovalueMethodNameto try to get the correct function name.fastrandand a usage of afastranduinnet: Added the otherfastrandmethods (fastrandn,fastrand64, andfastrandu) to the runtime.net/netip: Just some touchups and skipping a test.sync/atomic: Skipping some tests.syscall/js: Tiny cleanupAfter this update go1.19 should be getting very close.