10000 go1.19: Fix reflect by grantnelson-wf · Pull Request #1253 · gopherjs/gopherjs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

go1.19: Fix reflect #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2023
Merged

go1.19: Fix reflect #1253

merged 4 commits into from
Dec 6, 2023

Conversation

grantnelson-wf
Copy link
Collaborator
@grantnelson-wf grantnelson-wf commented Dec 4, 2023 •
edited
Loading

Two changes to go1.19:

  • Reflect fix: Since go1.19 is hitting CI issues from the missing generics, this copy/paste mistake wasn't caught until further testing against the generics branch.
  • Merge master changes

@grantnelson-wf grantnelson-wf changed the title Reflect fix & Merge master changes go1.19: Fix reflect Dec 5, 2023
@grantnelson-wf grantnelson-wf marked this pull request as ready for review December 5, 2023 15:54
@nevkontakte nevkontakte merged commit 0eb9c04 into gopherjs:go1.19 Dec 6, 2023
@grantnelson-wf grantnelson-wf deleted the reflectFix branch December 6, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevkontakte nevkontakte nevkontakte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grantnelson-wf @nevkontakte
0