8000 test-framework: Support testing with multiple accounts by mschuwalow · Pull Request #1779 · golemcloud/golem · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test-framework: Support testing with multiple accounts #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 26, 2025
Merged

test-framework: Support testing with multiple accounts #1779

merged 8 commits into from
Jun 26, 2025
+4,363 −3,812

Conversation

mschuwalow
Copy link
Contributor
@mschuwalow mschuwalow commented Jun 25, 2025 •
edited
Loading
  • all individual components in the test-framework have no knowledge of "current" accounts anymore
  • TestDsl is no longer implemented directly implemented for TestDependencies, but you rather select whether you want to use admin or a normal (ad-hoc created) using .admin() and .user(). These have access to the account_id and token, so you can script things not supported by the TestDsl using the raw clients using these

In practice the hierarchy is now something like this for the test-framework:

raw clients (grpc/http) < specific services like ComponentService (abstracts over / hides the underlying client) < TestDsl (hides / abstracts users and authentication)

@mschuwalow mschuwalow self-assigned this Jun 25, 2025
@mschuwalow mschuwalow force-pushed the shared-plugin-testing branch from 6c2d5bd to b6df714 Compare June 25, 2025 15:57
@mschuwalow mschuwalow marked this pull request as ready for review June 25, 2025 16:06
@afsalthaj
Copy link
Contributor
afsalthaj commented Jun 26, 2025 •
edited
Loading

LGTM

(except for certain patterns such as executor.into_admin() - and i would consider it as a minor thing).

@mschuwalow mschuwalow merged commit 2684508 into main Jun 26, 2025
44 of 45 checks passed
@mschuwalow mschuwalow deleted the shared-plugin-testing branch June 26, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afsalthaj afsalthaj afsalthaj approved these changes

Assignees

@mschuwalow mschuwalow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschuwalow @afsalthaj
0