8000 feat: close expired conn as soon as possible by chanxuehong · Pull Request #39450 · golang/go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: close expired conn as soon as possible #39450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: close expired conn as soon as possible #39450

wants to merge 1 commit into from

Conversation

chanxuehong
Copy link
Contributor

see #39449

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://github.com/golang/go/wiki/CommitMessage

  • The PR title is formatted as follows: net/http: frob the quux before blarfing
    • The package name goes before the colon
    • The part after the colon uses the verb tense + phrase that completes the blank in,
      "This change modifies Go to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible. ideally under 76 characters or shorter
  • No Markdown
  • The first PR comment (this one) is wrapped at 76 characters, unless it's
    really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Fixes #1234 or Updates #1234
    (the latter if this is not a complete fix) to this comment
  • If referring to a repo other than golang/go you can use the
    owner/repo#issue_number syntax: Fixes golang/tools#1234
  • We do not use Signed-off-by lines in Go. Please don't add them.
    Our Gerrit server & GitHub bots enforce CLA compliance instead.
  • Delete these instructions once you have read and applied them

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jun 7, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 06258d1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/236877 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Daniel Theophanes:

Patch Set 1: Code-Review-2

You need to start with an issue. Please file one at golang.org/issue. If one already exists that demonstrates what you are trying to do with this change, please reference it with: "For #1234".

As is, the commit message is not clear why you are changing this. The code itself indicates this is probably the wrong approach. Regardless, I would like to understand what you are encountering. Please do file an issue, prefix the issue title with "database/sql".

Please don’t reply on this GitHub thread. Visit golang.org/cl/236877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Daniel Theophanes:

Patch Set 1:

Ah, this is for:

https://golang.org/issue/39449

I'll reply further on that issue.

Please don’t reply on this GitHub thread. Visit golang.org/cl/236877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e3629ac) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/236877 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: dafeabd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/236877 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chanxuehong @gopherbot @googlebot @heschi
0