8000 nacl/box: support anonymous seal/open by btoews · Pull Request #107 · golang/crypto · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

nacl/box: support anonymous seal/open #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

nacl/box: support anonymous seal/open #107

wants to merge 1 commit into from

Conversation

btoews
Copy link
Contributor
@btoews btoews commented Nov 4, 2019 •
edited
Loading

This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

@gopherbot
Copy link
Contributor

This PR (HEAD: 24c0085) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/205241 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@btoews
Copy link
Contributor Author
btoews commented Nov 4, 2019

In the past, I've used cgo to test libsodium/nacl interoperability and put this behind a build tag that I pass in during CI. This way you can get good verification of round trip encrypt/decrypt, sign/verify, etc... while still preventing the library from building with cgo in normal use. I'd be happy to add something like that here if it's considered useful.

@FiloSottile
Copy link
Contributor

FYI we don't comment on GitHub PRs, only on issues and on Gerrit.

We prefer not to have cgo tests, they are either hard to run on the builders or they break because they don't run on the builders. Some vectors generated from libsodium will do.

@gopherbot
Copy link
Contributor

Message from Ben Toews:

Patch Set 1:

Not sure if I'm doing this right. Removing myself and adding Filippo as reviewers.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Filippo Valsorda:

Patch Set 1: Run-TryBot+1

(13 comments)

Thank you! A bunch of nits, and an API question to discuss on the issue.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=bb2243da

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on linux-amd64-race:
See https://storage.googleapis.com/go-build-log/bf3ee57d/linux-amd64-race_6b0a6947.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

1 of 10 TryBots failed:
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/bf3ee57d/linux-amd64-race_6b0a6947.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Filippo Valsorda:

Patch Set 1:

Patch Set 1: TryBot-Result-1

1 of 10 TryBots failed:
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/bf3ee57d/linux-amd64-race_6b0a6947.log

(This is fixed if you rebase.)

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 9c8722c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/205241 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ben Toews:

Patch Set 2:

(12 comments)

I think I've addressed all the provided feedback.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Filippo Valsorda:

Patch Set 2: Run-TryBot+1

(2 comments)

Thank you!

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=473db227

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remembe 8000 r to publish your drafts!

@btoews btoews changed the title nacl/box: Support anonymous seal/open nacl/box: support anonymous seal/open Dec 3, 2019
@gopherbot
Copy link
Contributor

Message from Ben Toews:

Patch Set 4:

(1 comment)

Updated the GitHub PR text/title.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Filippo Valsorda:

Patch Set 4:

Ben, can you update the CL to take the public key in the Open API?

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@btoews
nacl/box: support anonymous seal/open
7d334cf 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.
@gopherbot
Copy link
Contributor

This PR (HEAD: 7d334cf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/crypto/+/205241 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Filippo Valsorda:

Patch Set 5: Run-TryBot+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a966ce4b

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 5: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/205241.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 19, 2019
@btoews @FiloSottile
nacl/box: support anonymous seal/open
becbf70 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

Change-Id: I22455f1b83595ec8a68d1861e635bd6cb0573f44
GitHub-Last-Rev: 7d334cf
GitHub-Pull-Request: #107
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205241
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/205241 has been merged.

@gopherbot gopherbot closed this Dec 19, 2019
@btoews btoews deleted the sodium-sealed-box branch December 19, 2019 19:50
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 28, 2022
@btoews @FiloSottile
nacl/box: support anonymous seal/open
60da451 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

Change-Id: I22455f1b83595ec8a68d1861e635bd6cb0573f44
GitHub-Last-Rev: 7d334cf861942ec63ad613b7f28fb6dd7a1f9992
GitHub-Pull-Request: golang/crypto#107
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205241
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 29, 2022
@btoews @c-expert-zigbee
nacl/box: support anonymous seal/open
e39e129 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

Change-Id: I22455f1b83595ec8a68d1861e635bd6cb0573f44
GitHub-Last-Rev: 7d334cf861942ec63ad613b7f28fb6dd7a1f9992
GitHub-Pull-Request: golang/crypto#107
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205241
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this pull request Mar 29, 2022
@btoews @c-expert-zigbee
nacl/box: support anonymous seal/open
76e7cf5 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

Change-Id: I22455f1b83595ec8a68d1861e635bd6cb0573f44
GitHub-Last-Rev: 7d334cf861942ec63ad613b7f28fb6dd7a1f9992
GitHub-Pull-Request: golang/crypto#107
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205241
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this pull request Feb 16, 2023
@btoews @FiloSottile
nacl/box: support anonymous seal/open
e41a0fc 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

Change-Id: I22455f1b83595ec8a68d1861e635bd6cb0573f44
GitHub-Last-Rev: 7d334cf861942ec63ad613b7f28fb6dd7a1f9992
GitHub-Pull-Request: golang/crypto#107
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205241
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this pull request Sep 15, 2023
@btoews @FiloSottile
nacl/box: support anonymous seal/open
a94a064 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

Change-Id: I22455f1b83595ec8a68d1861e635bd6cb0573f44
GitHub-Last-Rev: 7d334cf
GitHub-Pull-Request: golang#107
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205241
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
desdeel2d0m added a commit to desdeel2d0m/crypto that referenced this pull request Jul 1, 2024
@desdeel2d0m @FiloSottile
nacl/box: support anonymous seal/open
825012a 
This adds SealAnonymous and OpenAnonymous functions that implement the
libsodium "sealed box" functionality.

Fixes golang/go#35346

Change-Id: I22455f1b83595ec8a68d1861e635bd6cb0573f44
GitHub-Last-Rev: 7d334cf861942ec63ad613b7f28fb6dd7a1f9992
GitHub-Pull-Request: golang/crypto#107
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/205241
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/crypto/nacl: Support for libsodium "sealed box"
4 participants
@btoews @gopherbot @FiloSottile @googlebot
0