Implement BigQuery migration driver #1185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint all the things
|
Hi, just wondered if you had any feedback or comments on the above? @dhui |
|
It would be nice to have it onboard. |
|
the lock in this PR does not work if someone is executing multiple processes at the same time (like kubernetes pods). The lock should happen in database level not in process itself. |
zetaab
reviewed
Apr 29, 2025
| // can run at a time. Migrate will call this function before Run is called. | ||
| // If the implementation can't provide this functionality, return nil. | ||
| // Return database.ErrLocked if database is already locked. | ||
| func (b *BigQuery) Lock() error { |
There was a problem hiding this comment.
lock should be implemented in database level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for BigQuery migration driver.
We just noticed there is already an open PR for this (#881), so we can close it if the other one is approved.