8000 Remove Python 2 specific code by barrust · Pull Request #16 · goose3/goose3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove Python 2 specific code #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2017
Merged

Remove Python 2 specific code #16

merged 5 commits into from
Nov 9, 2017

Conversation

barrust
Copy link
Collaborator
@barrust barrust commented Nov 9, 2017
  • Remove six dependency
  • Standardize on urllib.parse for urlparse and urljoin
    • Remove handling try-except importing for python 2
    • Remove dependency on urllib3 for parsing a single url
  • Fixed a few instances of using a built-in name as a variable name
  • Converted file open / close to use context managers

@lababidi lababidi merged commit 26355be into goose3:master Nov 9, 2017
@barrust barrust deleted the fix-python2 branch December 11, 2017 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barrust @lababidi
0