fix to find Korean Stopwords #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@galaxytemple you'll need to add ahocorasick and write a test please |
|
@lababidi Thank you for your feedback. I added pyahocorasick and tests/test_stopwords.py |
added 2 commits
May 10, 2022 14:59
|
This PR looks good to me (all tests passed)! If there are no concerns I can merge and push a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
None
What does this implement/fix? Explain your changes.
In English, All words including StopWords are separated by spacing. We can simply find Stopwords using the HashSet.
But Korean StopWords are attached at a word without a space, so it requires another logic.
For example,
English : Nice to meet you ( 'to' and 'you' are Stopsword)
Korea : 만나서 반가워요 ( '요' is Stopsword )
You know, Aho-Corasick algorithm has been widely used for string matching due to its advantage of matching multiple string patterns in a single pass
So it's suitable
Any other comments?