8000 gen-stat: wip by m4rc1e · Pull Request #263 · googlefonts/gftools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

gen-stat: wip #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 26, 2020
Merged

gen-stat: wip #263

merged 22 commits into from
Nov 26, 2020

Conversation

m4rc1e
Copy link
Collaborator
@m4rc1e m4rc1e commented Oct 26, 2020

Generate a STAT table for each font in a variable font family using the GF axis registry.

@m4rc1e m4rc1e mentioned this pull request Oct 29, 2020
Merged
@m4rc1e m4rc1e force-pushed the gen-stat branch 3 times, most recently from 9f41629 to cac87bc Compare November 4, 2020 17:01
@m4rc1e
Copy link
Collaborator Author
m4rc1e commented Nov 19, 2020

I'm making decent progress. The tool can successfully add STAT tables to any family I throw at it. Here's Amstelvar's

Screenshot 2020-11-19 at 16 22 49

I want to try and release this tomorrow.

@m4rc1e
Copy link
Collaborator Author
m4rc1e commented Nov 25, 2020

@thlinard Any objections against dropping format 2 AxisValues since these aren't necessary in the latest version of Indesign?

Personally, I dislike format 2 axis values because they don't support linked values. This means we have to add another Regular AxisValue which is format 3 to the STAT which feels hacky.

@m4rc1e
Copy link
Collaborator Author
m4rc1e commented Nov 25, 2020

I've kept the fvar postscript names and nameID 25 as well.

@m4rc1e m4rc1e marked this pull request as ready for review November 26, 2020 11:55
@m4rc1e
Copy link
Collaborator Author
m4rc1e commented Nov 26, 2020

I'm done. I'll wait until this evening to merge just incase anyone has any comments. I'll then cut a new release.

@thlinard
Copy link
thlinard commented Nov 26, 2020 •
edited
Loading

Personally, I dislike format 2 axis values because they don't support linked values. This means we have to add another Regular AxisValue which is format 3 to the STAT which feels hacky.

Hi Marc,

Sorry, I thought I commented. You're right, the absence of linked values in format 2 is a design flaw. Without repeating the debate which had taken place on google/fonts#2391 about the interest and usefulness of format 2 for a UI more accessible to non-specialist users, it's true that this is no longer necessary for InDesign. So OK for format 1 + format 3.

I've kept the fvar postscript names and nameID 25 as well.

Perfect then. 😃

@m4rc1e
Copy link
Collaborator Author
m4rc1e commented Nov 26, 2020

Thanks Thomas! I'll merge this.

@m4rc1e m4rc1e merged commit 8e33f83 into googlefonts:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4rc1e @thlinard
0