[builder] add --experimental-extra-arg flag to pass down extra arguments to compilers #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and fontmake this is useful for ttx_diff.py to control e.g. whether to pass the --no-production-names flag to fontc and fontmake, we want to rename glyphs to their final production names by default when comparing fontc vs fontmake output but sometimes it useful to keep original human-readable glyph names for debugging.
since it works with both compilers...
anthrotype
added a commit
to googlefonts/fontc
that referenced
this pull request
May 13, 2025
requires change in gftools builder googlefonts/gftools#1106
cmyr
approved these changes
May 13, 2025
simoncozens
reviewed
May 13, 2025
| @@ -65,9 +66,8 @@ def modify_config(self, config: dict): | |||
| config["cleanUp"] = True | |||
| # disable running ttfautohint, because we had a segfault | |||
| config["autohintTTF"] = False | |||
| # set --no-production-names, because it's easier to debug | |||
| extra_args = config.get("extraFontmakeArgs") or "" | |||
There was a problem hiding this comment.
Isn't this already a way to get extra args to the compiler?
There was a problem hiding this comment.
well, that's the way if you start with a config. here ttx_diff wants to override the user config and to pass down some extra command line options
There was a problem hiding this comment.
this is where gftools builder gets called from ttx_diff.py
we want to inject some extra flag for fontc/fontmake. Are you suggesting that we modify the input yaml before passing it to gftools?
There was a problem hiding this comment.
Well, that's how I would do it - it would avoid special-case stuff like this. But either way works. So long as you had considered it and thought this was easier...
m4rc1e
added a commit
that referenced
this pull request
May 14, 2025
Revert "Merge pull request #1106 from googlefonts/experimental-extra-args@
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ttx_diff.py we'd like control whether to pass the
--no-production-namesflag down to fontc and fontmake or not..Which means, renaming glyphs to their final production names by default, but sometimes when useful keep original human-readable glyph names for debugging.
I added a catch-all flag which means we won't need extra flags if we'd like to support any additional options.