Move Github client from packager to own module #514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! I've just fixed up some parts so it should now work for the packager. I've done a quick test my end and it was fine for the commands I use. @RosaWagner could you test this pr by playing with the packager please? |
|
All the command I usually use are working fine |
RosaWagner
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packager module is very big, and contains lots of code, not all of which is related to packaging; in addition, the GitHub-y bits of it are also used by gftools-qa. I'm hoping to use them for something else too, but they need disentangling first.
I've tested that gftools qa still works after this, but not the packager bits.