8000 packager: rm --no-source flag by m4rc1e · Pull Request #496 · googlefonts/gftools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

packager: rm --no-source flag #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

m4rc1e
Copy link
Collaborator
@m4rc1e m4rc1e commented Feb 17, 2022

This PR removes the --no-source flag since our METADATA.pb files now accept the source field.

This also fixes #494

@m4rc1e m4rc1e requested a review from graphicore February 17, 2022 14:58
Copy link
Contributor
@graphicore graphicore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I didn't check if there are any artifacts of --no-source left despite of what you removed.

@m4rc1e
Copy link
Collaborator Author
m4rc1e commented Feb 17, 2022

The docs don't mention it and I'm fairly sure I've removed every reference.

@m4rc1e m4rc1e merged commit 6a525e3 into googlefonts:main Feb 17, 2022
@m4rc1e m4rc1e deleted the packager-src branch February 18, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packager: --no-source strips out language comments
2 participants
0