Detect script and pass to ttfautohint #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really nice. My only concern is we'll now be adding a script tag when we never used to. This could cause regressions but I don't know how bad they'll be. I'll see If I can do some render tests this week. |
|
Just a thought, why not include a bool option in the config file for this? could be something like |
|
Yeah, that'll work for me. Will do. |
|
Thanks Simon. I've just added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Noto build scripts pass a
-D<script>argument to ttfautohint to enable script-specific hinting adjustments. This is a nice idea, and we should do it if possible. Also, the way Noto implements it is horrible and arbitrary and I'd like to move Noto's build scripts to cleaner code based on gftools where possible.This checks whether a font file has a clear "winning" script (defined as having more than twice as many code points as any other script in the font) and, if ttfautohint has a script-specific handler for that script, passes the appropriate
-Dflag.