-
Notifications
You must be signed in to change notification settings - Fork 94
Add support for --tools-file
alias
#383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
Yuan325
added a commit
that referenced
this issue
Apr 3, 2025
Add `tools-file` flag and deprecate `tools_file` flag. This is not a breaking change. The old `tools_file` flag is still usable. User will see the following message when using `tools_file` flag: ``` Flag --tools_file has been deprecated, please use --tools-file instead 2025-04-03T10:09:12.803165-07:00 INFO "Initialized 2 sources." ``` Help command will reveal the new flag: ``` ... --telemetry-service-name string Sets the value of the service.name resource attribute for telemetry data. (default "toolbox") --tools-file string File path specifying the tool configuration. (default "tools.yaml") -v, --version version for toolbox ... ``` Fixes #383
kurtisvg
pushed a commit
that referenced
this issue
Apr 4, 2025
Add `tools-file` flag and deprecate `tools_file` flag. This is not a breaking change. The old `tools_file` flag is still usable. User will see the following message when using `tools_file` flag: ``` Flag --tools_file has been deprecated, please use --tools-file instead 2025-04-03T10:09:12.803165-07:00 INFO "Initialized 2 sources." ``` Help command will reveal the new flag: ``` ... --telemetry-service-name string Sets the value of the service.name resource attribute for telemetry data. (default "toolbox") --tools-file string File path specifying the tool configuration. (default "tools.yaml") -v, --version version for toolbox ... ``` Fixes #383
Yuan325
pushed a commit
that referenced
this issue
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.1...v0.3.0) (2025-04-04) ### Features * Add 'alloydb-ai-nl' tool ([#358](#358)) ([f02885f](f02885f)) * Add HTTP Source and Tool ([#332](#332)) ([64da5b4](64da5b4)) * Adding support for Model Context Protocol (MCP). ([#396](#396)) ([a7d1d4e](a7d1d4e)) * Added [toolbox-core](https://pypi.org/project/toolbox-core/) SDK – easily integrate Toolbox into any Python function calling framework ### Bug Fixes * Add `tools-file` flag and deprecate `tools_file` ([#384](#384)) ([34a7263](34a7263)), closes [#383](#383) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this issue
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.1...v0.3.0) (2025-04-04) ### Features * Add 'alloydb-ai-nl' tool ([#358](#358)) ([f02885f](f02885f)) * Add HTTP Source and Tool ([#332](#332)) ([64da5b4](64da5b4)) * Adding support for Model Context Protocol (MCP). ([#396](#396)) ([a7d1d4e](a7d1d4e)) * Added [toolbox-core](https://pypi.org/project/toolbox-core/) SDK – easily integrate Toolbox into any Python function calling framework ### Bug Fixes * Add `tools-file` flag and deprecate `tools_file` ([#384](#384)) ([34a7263](34a7263)), closes [#383](#383) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> 12222fe
github-actions bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this issue
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.0](googleapis/genai-toolbox@v0.2.1...v0.3.0) (2025-04-04) ### Features * Add 'alloydb-ai-nl' tool ([googleapis#358](googleapis#358)) ([f02885f](googleapis@f02885f)) * Add HTTP Source and Tool ([googleapis#332](googleapis#332)) ([64da5b4](googleapis@64da5b4)) * Adding support for Model Context Protocol (MCP). ([googleapis#396](googleapis#396)) ([a7d1d4e](googleapis@a7d1d4e)) * Added [toolbox-core](https://pypi.org/project/toolbox-core/) SDK – easily integrate Toolbox into any Python function calling framework ### Bug Fixes * Add `tools-file` flag and deprecate `tools_file` ([googleapis#384](googleapis#384)) ([34a7263](googleapis@34a7263)), closes [googleapis#383](googleapis#383) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> 12222fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: p1
Important issue which blocks shipping the next release. Will be fixed prior to next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
I often find myself tripping up and attempting to launch Toolbox with the
--tools-file
flag.The actual flag is
--tools_file
using an underscore... yet all other flags do not use this pattern.genai-toolbox/cmd/root.go
Line 108 in 64da5b4
Adding an alias for
--tools-file
is probably the best path forward to consolidate flag naming pattern without introducing a breaking change.The text was updated successfully, but these errors were encountered: