chore: Run tests with Node 15 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Node 15 system test fails with: This is the same failure we see with V8 canary test. |
e3a30f7 to
7b5784a
Compare
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 42.21% 42.21%
=======================================
Files 14 14
Lines 2061 2061
Branches 42 42
=======================================
Hits 870 870
Misses 1173 1173
Partials 18 18 Continue to review full report at Codecov.
|
kalyanac
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will also result in Node 15 prebuilt binaries being released.
Two changes were made to testing as part of allowing tests with Node 15 to pass:
npm run cleanis called when the test script exits. This ensures there are no stale binaries or javascript generated from typescript when the next test starts.nvmis installed in/binrather than/root. This is probably where is always should have been installed and eliminated permission issues duringnpm install. (I think the permission issues observed were related tonpm installusing a non-root user to run installation scripts combined with "/root" being the working directory).