8000 refactor!: drop support for Node 8, 11 by macieksmuga · Pull Request #135 · google/pprof-nodejs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor!: drop support for Node 8, 11 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [ 10, 12, 13, 14]
node: [ 10, 12, 14]
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ is enabled.
with v8's CPU and Heap profilers. You may need to install additional
dependencies to build this module.
* For Linux: `pprof` has prebuilt binaries available for Linux and Alpine
Linux for Node 10, 11, 12 and 14. No additional dependencies are required.
Linux for Node 10, 12 and 14. No additional dependencies are required.
* For other environments: when using `@google-cloud/profiler` on environments
that `pprof` does not have prebuilt binaries for, the module
[`node-gyp`](https://www.npmjs.com/package/node-gyp) will be used to
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
]
},
"engines": {
"node": ">=8.9.4 <10.0.0 || >=10.4.1"
"node": ">=10.4.1"
},
"binary": {
"module_name": "pprof",
Expand Down
14 changes: 0 additions & 14 deletions system-test/Dockerfile.node11-alpine

This file was deleted.

2 changes: 1 addition & 1 deletion system-test/system_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if [[ "$RUN_ONLY_V8_CANARY_TEST" == "true" ]]; then
NVM_NODEJS_ORG_MIRROR="https://nodejs.org/download/v8-canary"
NODE_VERSIONS=(node)
else
NODE_VERSIONS=(10 11 12 14)
NODE_VERSIONS=(10 12 14)
fi

for i in ${NODE_VERSIONS[@]}; do
Expand Down
2 changes: 1 addition & 1 deletion tools/build/build.sh
5442
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ mkdir -p "$ARTIFACTS_OUT"

npm install --quiet

for version in 8.0.0 10.0.0 11.0.0 12.0.0 14.0.0
for version in 10.0.0 12.0.0 14.0.0
do
./node_modules/.bin/node-pre-gyp configure rebuild package \
--target=$version --target_arch="x64"
Expand Down
0