chore: address follow-up comments to #69 #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f15a7af to
6d2a961
Compare
aalexand
reviewed
Jun 25, 2019
ts/src/time-profiler-bindings.ts
Outdated
| @@ -28,8 +28,9 @@ export function startProfiling(runName: string, includeLineInfo?: boolean) { | |||
| } | |||
|
|
|||
| export function stopProfiling( | |||
| runName: string, includeLineInfo?: boolean): TimeProfile { | |||
| return profiler.timeProfiler.stopProfiling(runName, includeLineInfo || false); | |||
| runName: string, includedLineInfo?: boolean): TimeProfile { | |||
There was a problem hiding this comment.
I would name the argument as includeLineInfo everywhere. I think there is an assumption that the same value for this argument must be passed to startProfiling and stopProfiling, so using the same name would help to express that.
6d2a961 to
5b75b09
Compare
|
PTAL |
aalexand
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.