Disable suggestion box footers/headers #1135

rushiiMachine · 2024-12-08T21:36:01Z

rushiiMachine
Dec 8, 2024

I would love a toggle for the suggestion box footers (or headers, I guess) like Tabキーで選択 , it's pretty useless once you've used mozc for a while.

They seem to be added here:

mozc/src/session/internal/session_output.cc

Lines 355 to 401 in e983ab8

    
           bool SessionOutput::FillFooter(const commands::Category category, 
        
                                          commands::CandidateWindow *candidate_window) { 
        
             if (category != commands::SUGGESTION && category != commands::PREDICTION && 
        
                 category != commands::CONVERSION) { 
        
               return false; 
        
             } 
        
             bool show_build_number = true; 
        
             commands::Footer *footer = candidate_window->mutable_footer(); 
        
             if (category == commands::SUGGESTION) { 
        
               // TODO(komatsu): Enable to localized the message. 
        
               constexpr absl::string_view kLabel = "Tabキーで選択"; 
        
               // TODO(komatsu): Need to check if Tab is not changed to other key binding. 
        
               footer->set_label(kLabel); 
        
             } else { 
        
               // category is commands::PREDICTION or commands::CONVERSION. 
        
               footer->set_index_visible(true); 
        
               footer->set_logo_visible(true); 
        
               // If the selected candidate is a user prediction history, tell the user 
        
               // that it can be removed by Ctrl-Delete. 
        
               if (candidate_window->has_focused_index()) { 
        
                 for (size_t i = 0; i < candidate_window->candidate_size(); ++i) { 
        
                   const commands::CandidateWindow::Candidate &cand = 
        
                       candidate_window->candidate(i); 
        
                   if (cand.index() != candidate_window->focused_index()) { 
        
                     continue; 
        
                   } 
        
                   if (cand.has_annotation() && cand.annotation().deletable()) { 
        
                     // TODO(noriyukit): Change the message depending on user's keymap. 
        
           #if defined(__APPLE__) 
        
                     constexpr absl::string_view kDeleteInstruction = 
        
                         "control+fn+deleteで履歴から削除"; 
        
           #elif defined(OS_CHROMEOS) 
        
                     constexpr absl::string_view kDeleteInstruction = 
        
                         "ctrl+alt+backspaceで履歴から削除"; 
        
           #else   // !__APPLE__ && !OS_CHROMEOS 
        
                     constexpr absl::string_view kDeleteInstruction = 
        
                         "Ctrl+Delで履歴から削除"; 
        
           #endif  // __APPLE__ || OS_CHROMEOS 
        
                     footer->set_label(kDeleteInstruction); 
        
                     show_build_number = false; 
        
                   } 
        
                   break; 
        
                 } 
        
               } 
        
             }

hiroyuki-komatsu · 2024-12-10T16:21:08Z

hiroyuki-komatsu
Dec 10, 2024
Maintainer

Hi rushiiMachine,
Thanks for the screenshot. It's helpful for me to understand your situation.

It looks you use Fcitx. So I'd suggest you to talk with the Fcitx project team.
As the function name describes, that label is expected to be displayed on the footer.

3 replies

wengxt Dec 11, 2024

Regardless it's at top or bottom in fcitx, is it Ok to not display this field at all, or is there any critical usage of this field that may affect usability?

rushiiMachine Dec 11, 2024
Author

They seem to be just shortcut hints -- I don't think there's anything critical about them.

I created a discussion in the fcitx5 repo!

hiroyuki-komatsu Dec 12, 2024
Maintainer

So far, the footer label is used as a supplemental information, but it is designed to be visible to the user.

My suggestion is to display it to the footer area.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable suggestion box footers/headers #1135

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 1 comment 3 replies

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Disable suggestion box footers/headers #1135

rushiiMachine Dec 8, 2024

Replies: 1 comment · 3 replies

hiroyuki-komatsu Dec 10, 2024 Maintainer

wengxt Dec 11, 2024

rushiiMachine Dec 11, 2024 Author

hiroyuki-komatsu Dec 12, 2024 Maintainer

rushiiMachine
Dec 8, 2024

Replies: 1 comment 3 replies

hiroyuki-komatsu
Dec 10, 2024
Maintainer

rushiiMachine Dec 11, 2024
Author

hiroyuki-komatsu Dec 12, 2024
Maintainer