8000 chore: ensure that e2e tests cleanup clusters by garethgeorge · Pull Request #1057 · google/kf · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: ensure that e2e tests cleanup clusters #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore: ensure that e2e tests cleanup clusters #1057

merged 1 commit into from
Oct 17, 2023

Conversation

garethgeorge
Copy link
Collaborator
@garethgeorge garethgeorge commented Oct 16, 2023 •
edited
Loading

Ensures that the delete clusters flow executes even when

  • cluster turnup succeeds partially (e.g. cluster created but various kubectl apply operations fail)
  • other testing stages fail

This reduces resource waste in our integration testing project.

@garethgeorge
Copy link
Collaborator Author

Thanks @guangyw

@garethgeorge garethgeorge merged commit 01482b3 into main Oct 17, 2023
@garethgeorge garethgeorge deleted the garethgeorge/testfix branch October 17, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangyw guangyw guangyw approved these changes

@balamut-google balamut-google Awaiting requested review from balamut-google

Assignees

@balamut-google balamut-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garethgeorge @guangyw @balamut-google
0