fix: set-env may behave incorrectly if variables provided are lowercase #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HKWinterhalter
approved the
8000
se changes
Oct 11, 2023
skakauridze-clgx
added a commit
to skakauridze-clgx/kf
that referenced
this pull request
Nov 15, 2023
PR: google#1049 is breaking .net Core applications, where lower case environrment variables are expected. Proposing this change, before better fix is available
garethgeorge
pushed a commit
that referenced
this pull request
Nov 15, 2023
PR: #1049 is breaking .net Core applications, where lower case environment variables are expected. Proposing this change, before better fix is available <!-- Include the issue number below --> Fixes # ## Proposed Changes * * * ## Release Notes <!-- kf follows the Keep A Changelog standard for release notes. https://keepachangelog.com/en/1.0.0/ Changelog entries should be one per line and start with one of the following words: `Added` for new features. `Changed` for changes in existing functionality. `Deprecated` for soon-to-be removed features. `Removed` for now removed features. `Fixed` for any bug fixes. `Security` in case of vulnerabilities. If one of the changes is breaking include that as a second word e.g. Removed BREAKING support for manifests v1 --> ```release-note ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
kf set-env FOOfollowed bykf set-env foomay add both to the environment even though they will be interpreted as the same var by kubernetes.