8000 Fix macos error for std::max type by j2kun · Pull Request #1698 · google/heir · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix macos error for std::max type #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000
Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Fix macos error for std::max type #1698

merged 1 commit into from
Apr 10, 2025

Conversation

j2kun
Copy link
Collaborator
@j2kun j2kun commented Apr 10, 2025 •
edited
Loading

Fixes #1696

Tested on my local macbook. (I wonder if we could make it so the macOS CI runs when a PR is tagged with a given label? [edit]: yes this is possible!)

@j2kun j2kun requested a review from asraa April 10, 2025 15:53
@j2kun j2kun changed the title Fix https://github.com/google/heir/issues/1696 Fix macos error for std::max type Apr 10, 2025
@asraa asraa added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Apr 10, 2025
@copybara-service copybara-service bot merged commit 39767ba into google:main Apr 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS build error
2 participants
@j2kun @asraa
0