8000 Add issue `Type` to `IssueRequest` by cpanato · Pull Request #3567 · google/go-github · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add issue Type to IssueRequest #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Add issue Type to IssueRequest #3567

merged 1 commit into from
Apr 30, 2025

Conversation

cpanato
Copy link
Contributor
@cpanato cpanato commented Apr 30, 2025

With he new field for Issue Type, we can also update that field in the edit method, adding that to be able to use it.
updating the tests to add that as well

https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#update-an-issue

cc @gmlewis

@gmlewis gmlewis changed the title add issue type to the IssueRequest to be able to update this field Add issue Type to IssueRequest Apr 30, 2025
@gmlewis
Copy link
Collaborator
gmlewis commented Apr 30, 2025

Thank you, @cpanato. Please run step 4 of CONTRIBUTING.md and push the changes to this PR.

@codecov Codecov
Copy link
codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.24%. Comparing base (6a7684f) to head (0c7ace0).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3567      +/-   ##
==========================================
+ Coverage   91.23%   91.24%   +0.01%     
==========================================
  Files         183      183              
  Lines       16053    16075      +22     
==========================================
+ Hits        14646    14668      +22     
  Misses       1231     1231              
  Partials      176      176

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cpanato
add issue type to the IssueRequest to be able to update this field
0c7ace0 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Contributor Author
cpanato commented Apr 30, 2025

Thank you, @cpanato. Please run step 4 of CONTRIBUTING.md and push the changes to this PR.

sorry @gmlewis forgot to run those, pushed the changes after running the scripts

gmlewis
gmlewis approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator
@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cpanato!
LGTM.
Merging

@gmlewis gmlewis merged commit c9e1ad0 into google:master Apr 30, 2025
7 checks passed
@cpanato cpanato deleted the add-edit-type branch April 30, 2025 13:06
@gmlewis gmlewis mentioned this pull request May 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpanato @gmlewis
0