8000 Fix tests for physical TPMs by jkl73 · Pull Request #165 · google/go-tpm-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix tests for physical TPMs #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix tests for physical TPMs #165

merged 1 commit into from
Feb 17, 2022

Conversation

jkl73
Copy link
Contributor
@jkl73 jkl73 commented Feb 17, 2022 •
edited
Loading

Some tests were failing on some physical TPMs due to certain hash algos are not supported.
Changing them to SHA1 and SHA256 which most TPM2 chips should support.

Reset the Test PCR for certain tests where requiring the PCR bank to be zero value at the beginning of the test.

@jkl73
Fix tests for physical TPMs.
5d9eb6c 
Some tests were failing on some physical TPMs due to certain hash
algos are not supported. Changing them to SHA1 and SHA256 which
most TPM2 chips should support.
@jkl73 jkl73 marked this pull request as ready for review February 17, 2022 00:25
@jkl73 jkl73 requested a review from josephlr February 17, 2022 00:25
josephlr
josephlr approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member
@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, did you make sure these tests passed on a physical tpm?

@jkl73
Copy link
Contributor Author
jkl73 commented Feb 17, 2022

Nice fix, did you make sure these tests passed on a physical tpm?

All tests in client and cel passed. Some tests in server failed due to the PCR 0 replay issue on the system eventlog (maybe because I am using Debian).

@jkl73 jkl73 merged commit d0cad24 into google:master Feb 17, 2022
jessieqliu pushed a commit that referenced this pull request Mar 2, 2022
@jkl73 @jessieqliu
Fix tests for physical TPMs (#165)
49f3919 
Change hash in some tests to SHA1 and SHA256 which are supported by most TPM2
Add PCRReset for the the PCR (16) at the beginning of some tests
jessieqliu pushed a commit that referenced this pull request Mar 2, 2022
@jkl73 @jessieqliu
Fix tests for physical TPMs (#165)
2a89438 
Change hash in some tests to SHA1 and SHA256 which are supported by most TPM2
Add PCRReset for the the PCR (16) at the beginning of some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkl73 @josephlr
0