8000 Add OverrideEnvType and OverrideArgType for cel event by jkl73 · Pull Request #161 · google/go-tpm-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add OverrideEnvType and OverrideArgType for cel event #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2022
Merged

Add OverrideEnvType and OverrideArgType for cel event #161

merged 1 commit into from
Mar 8, 2022

Conversation

jkl73
Copy link
Contributor
@jkl73 jkl73 commented Feb 10, 2022 •
edited
Loading

Add cel event type for override env and override args.

One record will contain one env, so if there are multiple overriding env or args, there will be multiple records.

@jkl73 jkl73 requested a review from josephlr February 10, 2022 03:27
josephlr
josephlr approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member
@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the CEL types. The plan is still to just have two booleans in the machine state indicating if args (or respectively envs) were overwritten as part of container launch, correct?

@jkl73
Copy link
Contributor Author
jkl73 commented Feb 23, 2022

This looks good for the CEL types. The plan is still to just have two booleans in the machine state indicating if args (or respectively envs) were overwritten as part of container launch, correct?

Yes we will do that for now.
Later we can specify the actual overwritten args envs (strings instead of a boolean) in the machine state. That way trusted party can set a more granular rule on envs and args.

@josephlr josephlr merged commit 5363207 into google:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkl73 @josephlr
0