-
Notifications
You must be signed in to change notification settings - Fork 74
Add CEL replay and TPM extension in AppendEvent #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling AppendEvent, extend the target TPM's PCR for the event. Also update the tests with a TPM handle and style and add helper method for appending to a CEL. Finally, change PCRs to use Debug and Application because test.GetTPM can use a real TPM. This would clobber the values of 13 and 14 as the test stands.
jkl73
reviewed
Dec 9, 2021
iKevinY
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending resolving @jkl73's comments.
cel.replay takes a CEL's records and attempts to extend all of the record's digests for the given bank's hash algorithm. Finally, it compares the replay PCRs with the bank PCRs.
Test empty CEL, extending and replaying against two PCRs, replay failure on tampering with the CEL, and superset/subset testing on input PCR bank to verify against.
Allows client.Attest users to pass in TCG Canonical Event Logs and use them in the output Attestation message.
jkl73
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.