Add client.Attest #106
Merged
Add client.Attest #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows verification to be checked client side, and this functionaliy makes more sense as a method. Signed-off-by: Joe Richey <joerichey@google.com>
This means that: - We now do a PCR Read in client.Quote() - Quote.Verify no longer needs to take a Pcrs parameter - Our tests can be slightly simplified Signed-off-by: Joe Richey <joerichey@google.com>
This runs a sanity check client side, so that if there is an issue, we get a client error. Note this change _is not_ for security, the server still must verify the quote, it is just for reliablity/ergonomics. Signed-off-by: Joe Richey <joerichey@google.com>
Add a list of all checks we perform (to make auditing easier). Also change the parameter names to better reflect their purpose Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
Both ReadAllPCRs and Attest will need this functionality Signed-off-by: Joe Richey <joerichey@google.com>
Signed-off-by: Joe Richey <joerichey@google.com>
|
@iKevinY PTAL, this should be all the code needed client-side |
Changes LGTM overall (will let others do the formal code review). |
jkl73
reviewed
Jun 18, 2021
Yes, there will be two types of tests:
|
jkl73
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an
Attestmethod toKey, as well as some smaller organizational changes aroundQuote.Verify. See the individual commits for more information.Things that are still needed (will be in other PRs):