Add client.ReadAllPCRs and use it in "gotpm read pcr" #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function queries the TPM for it's PCRs and then reads all the PCRs from all banks. Signed-off-by: Joe Richey <joerichey@google.com>
Adds in a tpm2_readpcr style formatting for the PCR proto. Having this be a method on the Pcrs type allows users to use this formatting outside of the commandline tool. Signed-off-by: Joe Richey <joerichey@google.com>
"gotpm read pcr" and "gotpm seal" need different default behavior when a user doesn't specify a hash algorithm. So we now just have the subcommand manage the tpm2.Algorithm variable itself, allowing different subcommands to have different default values. Also, we now no longer need getSelection(), subcommands can just create the selection manually. Signed-off-by: Joe Richey <joerichey@google.com>
This is a *breaking change*, but not a huge one. The format is also now more consistent with the output of "tpm2 readpcr". Signed-off-by: Joe Richey <joerichey@google.com>
This makes displaying default values easier. Signed-off-by: Joe Richey <joerichey@google.com>
This avoids certain "device busy" errors on some Linux distros Signed-off-by: Joe Richey <joerichey@google.com>
jkl73
reviewed
Jun 18, 2021
Signed-off-by: Joe Richey <joerichey@google.com>
jkl73
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also includes some other minor cleanups for the command line tool:
tpm2-toolsdoes)gotpm read pcrandgotpm sealcan still both use--hash-algo, but have different default values/dev/tpmrm0by default.