Remove EnableSignedContainerCache + EnableMeasureMemoryMonitor from container launcher #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
945a495 to
de37af5
Compare
|
/gcbrun |
JoshuaKrstic
reviewed
Oct 1, 2024
launcher/agent/agent_test.go
Outdated
| }, | ||
| { | ||
| name: "enable signed container", | ||
| name: "all experiment flags disabled", |
There was a problem hiding this comment.
maybe we rename this now that theyre gone?
"Happy path" or something
JoshuaKrstic
approved these changes
Oct 1, 2024
…ontainer launcher
de37af5 to
c29c90c
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused EnableSignedContainerCache + EnableMeasureMemoryMonitor from container launcher