Add mutex to failing client to prevent concurrent writes #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec86f6 to
4d58e07
Compare
|
/gcbrun |
alexmwu
approved these changes
Sep 20, 2024
yawangwang
reviewed
Sep 20, 2024
4d58e07 to
fd81ad0
Compare
|
/gcbrun |
yawangwang
approved these changes
Sep 20, 2024
|
TestFetchAndWriteTokenWithTokenRefresh has been flaky a while, rerunning it |
jkl73
approved these changes
Sep 20, 2024
jessieqliu
pushed a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Joshua Krstic <jkrstic@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is failing unit tests sometimes:
=== RUN TestFetchContainerImageSignatures_RetriesOnFailure/two_repos,_no_failures
fatal error: concurrent map writes
fatal error: concurrent map writes