8000 add custom nonce flag to cmd package token subcommand by Ruide · Pull Request #451 · google/go-tpm-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add custom nonce flag to cmd package token subcommand #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

add custom nonce flag to cmd package token subcommand #451

merged 1 commit into from
May 31, 2024

Conversation

Ruide
Copy link
Collaborator
@Ruide Ruide commented May 17, 2024
  • add a custom-nonce flag to allow user supplied string array for Custom Nonce
  • added the flag in token subcommand for generating tokens with the custom nonce field
  • added the flag in unit test

@Ruide Ruide requested a review from alexmwu May 17, 2024 18:07
@Ruide
Copy link
Collaborator Author
Ruide commented May 17, 2024

/gcbrun

@Ruide Ruide requested review from jkl73 and JoshuaKrstic May 22, 2024 23:21
@Ruide Ruide requested a review from JoshuaKrstic May 29, 2024 20:02
alexmwu
alexmwu requested changes May 29, 2024
View reviewed changes
Copy link
Contributor
@alexmwu alexmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that uses custom nonce and the fake verifier

@Ruide Ruide force-pushed the add-custom-nonce-flag branch from e1c397f to f0588c9 Compare May 29, 2024 23:56
@Ruide Ruide requested a review from alexmwu May 29, 2024 23:57
@Ruide
Copy link
Collaborator Author
Ruide commented May 29, 2024

/gcbrun

alexmwu
alexmwu approved these changes May 30, 2024
View reviewed changes
@Ruide Ruide force-pushed the add-custom-nonce-flag branch from f0588c9 to 3be9f02 Compare May 31, 2024 01:03
@Ruide
Copy link
Collaborator Author
Ruide commented May 31, 2024

/gcbrun

@Ruide Ruide merged commit ddd3734 into google:main May 31, 2024
11 checks passed
@Ruide Ruide deleted the add-custom-nonce-flag branch May 31, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmwu alexmwu alexmwu approved these changes

@JoshuaKrstic JoshuaKrstic JoshuaKrstic approved these changes

@jkl73 jkl73 Awaiting requested review from jkl73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ruide @alexmwu @JoshuaKrstic
0