Fix releaser.yaml and ci.yml file on macos #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
931853e to
ab4b5ed
Compare
3f8405f to
07ed83c
Compare
|
/gcbrun |
alexmwu
requested changes
May 7, 2024
Add openssl lib location for darwin arm64
alexmwu
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause:
macos-latest no longer gives us an amd64 machine to build and run our test (even if we ask for an amd64 machine specifically, I tested using uname, and it's still a arm64 mac)
https://github.com/actions/runner-images/tree/main
Changes:
Specifically add
macos-latest/arm64to the build/testAdd
macos-14-largewhich supports amd64Adding openssl lib location (homebrew) for
darwin/arm64Remove
macos-latestfrom releaser file, as we don't need to run the releaser in different OSes. And sincegotpmbinary doesn't need the simulator CGO support, the linux should handle the cross compilation for all platform/arch when doing the release. This should also fix the error when we creating a release (because we were trying to release the same binary twice)