8000 Fix nil dereference in worker and move to filepath.WalkDir by jklong · Pull Request #45 · google/fswalker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix nil dereference in worker and move to filepath.WalkDir #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2024
Merged

Fix nil dereference in worker and move to filepath.WalkDir #45

merged 2 commits into from
Apr 2, 2024

Conversation

jklong
Copy link
Contributor
@jklong jklong commented Apr 2, 2024

fix: check for nil os.DirEntry passed to the worker WalkDirFunc.
feat: move to more efficient filepath.WalkDir instead of filepath.Walk.

@jklong
fix: check for nil os.DirEntry passed to the worker WalkDirFunc.
07bb18b 
feat: move to more efficient `filepath.WalkDir` instead of
`filepath.Walk`.
@jklong jklong requested review from fhchstr, kuuzzzy and a team as code owners April 2, 2024 14:57
fhchstr
fhchstr requested changes Apr 2, 2024
View reviewed changes
Copy link
Member
@fhchstr fhchstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Minor nits. LGTM otherwise.

fhchstr
fhchstr approved these changes Apr 2, 2024
View reviewed changes
@fhchstr fhchstr merged commit 88581dc into google:master Apr 2, 2024
@jklong jklong deleted the walker branch April 2, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhchstr fhchstr fhchstr approved these changes

@kuuzzzy kuuzzzy Awaiting requested review from kuuzzzy kuuzzzy is a code owner

Assignees

@jklong jklong

@fhchstr fhchstr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jklong @fhchstr
0