8000 fix(scripts): do not allow running scripts as root; prevent accidental mishaps; update rust checks by yesudeep · Pull Request #259 · google/dotprompt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(scripts): do not allow running scripts as root; prevent accidental mishaps; update rust checks #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

fix(scripts): do not allow running scripts as root; prevent accidental mishaps; update rust checks #259

merged 1 commit into from
May 4, 2025
+278 −525

Conversation

yesudeep
Copy link
Collaborator
@yesudeep yesudeep commented May 4, 2025

CHANGELOG:

  • Fix scripts so that the fail when run as root to prevent
    accidental mishaps.
  • Update rust lint checks.
  • Handlebarrz has linker errors when built individually, so exclude
    temporarily from workspace Cargo.toml.
  • Move handlebarrz-specific script to scripts/run_handlebarrz_tests
  • Add scripts to test rust code with nightly (non-failing) and stable.

@yesudeep yesudeep marked this pull request as draft May 4, 2025 19:47
@github-actions github-actions bot added documentation Improvements or additions to documentation python config root fix labels May 4, 2025
@yesudeep
fix(scripts): do not allow running scripts as root; prevent accidenta…
45de398 
…l mishaps; update rust checks

CHANGELOG:
- [ ] Fix scripts so that the fail when run as root to prevent
  accidental mishaps.
- [ ] Update rust lint checks.
- [ ] Handlebarrz has linker errors when built individually, so exclude
  temporarily from workspace Cargo.toml.
- [ ] Move handlebarrz-specific script to scripts/run_handlebarrz_tests
- [ ] Add scripts to test rust code with nightly (non-failing) and stable.
@yesudeep yesudeep force-pushed the yesudeep/fix/penitent-light branch from bd6ac59 to 45de398 Compare May 4, 2025 19:49
@yesudeep yesudeep marked this pull request as ready for review May 4, 2025 19:52
@yesudeep yesudeep merged commit 5cc067d into main May 4, 2025
15 checks passed
@yesudeep yesudeep deleted the yesudeep/fix/penitent-light branch May 4, 2025 19:52
@github-actions github-actions bot mentioned this pull request May 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyasingh1902 tanyasingh1902 tanyasingh1902 approved these changes

@rutujaD1999 rutujaD1999 Awaiting requested review from rutujaD1999

Assignees
No one assigned
Labels
config documentation Improvements or additions to documentation fix python root
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yesudeep @tanyasingh1902
0