8000 [Py]Implement the dotprompt.ts in python · Issue #90 · google/dotprompt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Py]Implement the dotprompt.ts in python #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Manurajbharath opened this issue Feb 28, 2025 · 0 comments
Closed

[Py]Implement the dotprompt.ts in python #90

Manurajbharath opened this issue Feb 28, 2025 · 0 comments
Assignees
@yesudeep
Labels
python

Comments

@Manurajbharath
Copy link

No description provided.

@Manurajbharath Manurajbharath moved this to In progress in Dotprompt Feb 28, 2025
@Manurajbharath Manurajbharath self-assigned this Feb 28, 2025
@yesudeep yesudeep assigned r8zr and yesudeep and unassigned r8zr and Manurajbharath Mar 19, 2025
yesudeep added a commit that referenced this issue Mar 24, 2025
@yesudeep
feat(py): implement identify_partials in terms of regexps since we do…
402e17f 
… not have an AST to walk #90

ISSUE: #90

The JS implementation of Handlebars exposes a parse method that
returns an AST, which the `dotprompt.ts` implementation walks
to identify partials in the template. Since, we couldn't find any
methods in the Rust implementation yet that expose this functionality,
we've resorted to using regular expressions to match and find
partials in the template for now.

CHANGELOG:
- [ ] Use regexps to find partials in the template.
- [ ] Add unit tests.
- [ ] Fix some doc comments.
@yesudeep yesudeep mentioned this issue Mar 24, 2025
Merged
3 tasks
yesudeep added a commit that referenced this issue Mar 24, 2025
@yesudeep
feat(py): implement identify_partials in terms of regexps since we do…
f802275 
… not have an AST to walk #90 (#150)

ISSUE: #90

The JS implementation of Handlebars exposes a parse method that
returns an AST, which the `dotprompt.ts` implementation walks
to identify partials in the template. Since, we couldn't find any
methods in the Rust implementation yet that expose this functionality,
we've resorted to using regular expressions to match and find
partials in the template for now.

CHANGELOG:
- [ ] Use regexps to find partials in the template.
- [ ] Add unit tests.
- [ ] Fix some doc comments.
This was referenced Mar 25, 2025
Closed
Open
Open
@yesudeep yesudeep closed this as completed by moving to Done in Dotprompt May 7, 2025
@yesudeep yesudeep moved this from In progress to Done in Dotprompt May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yesudeep yesudeep

Labels
python
Projects
Dotprompt
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yesudeep @Manurajbharath @r8zr
0