8000 Remove docsy's custom shortcode 'figure' by deining · Pull Request #2175 · google/docsy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove docsy's custom shortcode 'figure' #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove docsy's custom shortcode 'figure' #2175

merged 1 commit into from
Jan 21, 2025

Conversation

deining
Copy link
Collaborator
@deining deining commented Jan 16, 2025

This PR follows up on the discussion raised in #2174. We safely can remove docsy's custom figure shortcode, it has no advantages over hugo's built-in figure shortcode.

This PR resolves #2174.

@deining deining changed the title Remove shortcode 'figure' Remove docsy's custom shortcode 'figure' Jan 16, 2025
@deining deining force-pushed the remove-figure-shortcode branch from aea2094 to 6eef861 Compare January 16, 2025 21:17
@chalin chalin force-pushed the remove-figure-shortcode branch from 6eef861 to 2edb367 Compare January 20, 2025 23:06
@chalin
Copy link
Collaborator
chalin commented Jan 20, 2025 •
edited
Loading

@LisaFC @emckean @geriom - any feedback on this? I haven't done a detailed compare of the shortcodes, but I'm inclined to fall back to the more modern version provided by Hugo.

@deining - build checks are failing; locally run npm run fix:format and pushing the changes to resolve the issues.

@chalin chalin added this to the 25Q1 milestone Jan 20, 2025
@LisaFC
Copy link
Collaborator
LisaFC commented Jan 21, 2025

LGTM!

chalin
chalin approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator
@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @LisaFC.

@deining - LGTM once the CHANGELOG formatting is fixed. It might be easier to undo all the changes and only add the one bullet.

If you are using Prettier to reformat, make sure you're using the latest version.

@deining deining force-pushed the remove-figure-shortcode branch from 2edb367 to e1bc1e3 Compare January 21, 2025 20:16
@deining
Copy link
Collaborator Author
deining commented Jan 21, 2025

All checkers are green now! Looking forward seeing this PR merged!

@deining deining requested a review from chalin January 21, 2025 20:24
@chalin chalin merged commit 7b3eaa4 into google:main Jan 21, 2025
11 checks passed
@deining deining deleted the remove-figure-shortcode branch January 21, 2025 21:39
marshalc pushed a commit to ouhft/docsy that referenced this pull request Jan 30, 2025
@rbfmarshallc
Squashed commit of the following:
823b9bc 
commit 77da7e4
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Thu Jan 30 06:08:47 2025 -0500

    Fix language-drop style when in left nav (google#2183)

commit a854cb3
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Thu Jan 23 20:21:54 2025 -0500

    Update Hugo to 0.142.0, and more (google#2182)

commit 7b3eaa4
Author: Andreas Deininger <andreas@deininger.net>
Date:   Tue Jan 21 21:28:01 2025 +0100

    Remove docsy's custom shortcode 'figure' (google#2175)

commit 258d3e5
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Tue Jan 21 14:48:14 2025 -0500

    Drop style attribute using undef CSS var (google#2180)

commit ef59ee7
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Mon Jan 20 17:47:51 2025 -0500

    [CI] Upgrade NPM packages (google#2179)

commit 9c41490
Author: Andreas Deininger <andreas@deininger.net>
Date:   Mon Jan 20 23:29:41 2025 +0100

    Fix error when building user guide with latest hugo version 0.141.0 (google#2177)

commit e6d9477
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Fri Jan 10 11:30:19 2025 -0500

    Breadcrumb for blog pages, and per-page/section config (google#2161)

commit 9fbb3a6
Author: Andreas Deininger <andreas@deininger.net>
Date:   Thu Jan 9 22:10:40 2025 +0100

    Bump KaTeX to latest version (google#2168)

commit a9ea2b7
Author: Peter Dave Hello <hsu@peterdavehello.org>
Date:   Fri Jan 10 00:51:45 2025 +0800

    Update and improve zh-TW Traditional Chinese locale (google#2158)

    Co-authored-by: ChengHao Yang <tico88612@gmail.com>

commit 1b3fc5a
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Thu Jan 9 08:47:53 2025 -0500

    Userguide config cleanup, drop pygments config (google#2166)

commit 88ec5ae
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Thu Jan 9 08:40:44 2025 -0500

    Render-heading: process class attributes (google#2165)

commit dd5e69b
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Wed Jan 8 12:46:18 2025 -0500

    Hide index-page single breadcrumb (google#2160)

commit 30a6c34
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Wed Jan 8 12:18:17 2025 -0500

    Blog list layout whitespace cleanup (google#2159)

commit 3aa3dc7
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Wed Jan 8 11:49:09 2025 -0500

    Blog list layout: display the page title and content (google#2157)

commit 6c22754
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Tue Jan 7 17:04:11 2025 -0500

    Blog list layout refactoring (google#2155)

commit 95a08e1
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Tue Jan 7 12:49:26 2025 -0500

    [CI] Upgrade NPM pkgs, Hugo to 0.140.2 (google#2154)

commit 2f361b2
Author: rinsuki <428rinsuki+git@gmail.com>
Date:   Sun Jan 5 02:09:10 2025 +0900

    i18n: Add feedback_* to i18n/ja.toml (google#2149)

commit fa81a86
Author: Andreas Deininger <andreas@deininger.net>
Date:   Fri Jan 3 22:59:17 2025 +0100

    Bump dependency Font-Awesome to latest version 6.7.2 (google#2151)

commit 67f6b6a
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Thu Dec 12 13:27:01 2024 -0500

    Blog 2024 review: Add link to LFX mentorships (google#2147)

commit f3e6ca9
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Thu Dec 12 12:41:08 2024 -0500

    Blog 2024 year in review (google#2145)

commit 99c2842
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Thu Dec 12 10:05:14 2024 -0500

    [CI] Upgrade NPM pkgs, Hugo to 0.139.4 (google#2143)

commit dd72a27
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Sat Nov 23 06:34:07 2024 -0500

    [CI] Patch search page HTML until Hugo is fixed, FA upgrade (google#2135)

commit fed2d28
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Wed Nov 20 06:09:53 2024 -0500

    Upgrade Hugo and FontAwesome (google#2129)

commit 97dadaa
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Tue Nov 19 18:48:09 2024 -0500

    [CI] Handle creation of empty Hugo-modules for deps (google#2128)

commit 2a6ecfc
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Tue Nov 19 17:33:23 2024 -0500

    Update CHANGELOG.md: fix copy-paste error (google#2127)

commit 706e23c
Author: Shihyu <methodho@gmail.com>
Date:   Sat Nov 16 23:29:23 2024 +0800

    Fix typo in deployment documentation (google#2123)

commit aedef51
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Fri Nov 15 11:47:52 2024 -0500

    Upgrade Hugo and merge optional deps into dev (google#2125)

commit d1e6470
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Fri Nov 15 11:29:18 2024 -0500

    [CI] Restore format check as a part of `npm test` (google#2124)

commit 6e42d49
Author: Patrice Chalin <chalin@users.noreply.github.com>
Date:   Fri Nov 15 11:19:51 2024 -0500

    External link checking + project pages (google#2120)
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
@deining @fekete-robert
Remove docsy's custom shortcode 'figure' (google#2175)
c173057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin Awaiting requested review from chalin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
25Q1
Development

Successfully merging this pull request may close these issues.
3 participants
@deining @chalin @LisaFC
0