fix!: remove recycling logic from continous flyout #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
5137c71 to
25e444d
Compare
|
@BeksOmega is this good to be converted from a draft? |
Yep! All of my drafts should be gtg now. |
alschmiedt
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
The change LGTM! Just a few things in the package need to be updated.
- The peerDependency should be updated to
^7.20211209.0since recycling will no longer work when this package is used with any version below v7. - The major version should also be updated so that developers don't automatically get this change pulled in.
Also, if you could change the target branch to be master that would be great. Thanks!
25e444d to
f3ff53a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is dependent on changes made by the new JSO serialization system.
Removes the recycling logic from the continuous toolbox since it has been moved in to core.
Testing
Was not able to test whether this works correctly or not because it is dependent on changes in core, and linking is being uncooperative.Manually tested this by editing one of the shadows of the color blend block, and then creating a variable to refresh the flyout. The edits to the shadow were maintained, signaling that recycling was occuring.
API Change
Along with google/blockly#5392 this removes the protected
createBlock_andclearOldBlocks_functions from the public API