fix: Reenable support for tabbing between fields. #9049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
May 14, 2025
|
Can get tests added as part of #8915 |
BenHenning
reviewed
May 14, 2025
Comment on lines
+604
to
+606
| WidgetDiv.hideIfOwner(this); | ||
| dropDownDiv.hideWithoutAnimation(); | ||
| target.showEditor(); |
There was a problem hiding this comment.
Does this correctly focus the new field, too?
There was a problem hiding this comment.
Yes, ultimately it calls showInlineEditor() (on non-mobile) which calls focus() on the input.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8821
Proposed Changes
This PR re-adds support for tabbing between editable fields to correct a regression. This is a bit complicated because, in Zelos, navigation is to blocks rather than fields for simple reporters, but it appears to work correctly in both Zelos and non-Zelos renderers.