feat: add keyboard shortcut to open context menu #8921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now in favor of keeping this in the kbe until we move more code into core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8847
Proposed Changes
Reason for Changes
Test Coverage
Documentation
Additional Information
This change depends on #8917 which depends on changes to FocusManager to return the correct thing from
getFocusedNode. I manually madegetFocusedNodereturn the selected block, and the context menu behaved as expected when opened withcmd+enter, so I think this should "just work" when the prerequisites are done, at which point it should be rebased onto the v12 branch.