fix: Fix bug that prevented dismissing the widgetdiv in a mutator workspace. #8600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcallen
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8599
Proposed Changes
This PR updates
WidgetDiv.hideIfOwnerIsInWorkspace()to hide the widget div if its owner is an indirect child of the given workspace, e.g. the given workspace is the root workspace but the widget div is owned by a child of a mutator workspace. AFAIK workspaces are only ever nested one level deep in practice, but I'm not aware of anything that enforces that, so it attempts to walk up an arbitrarily deep workspace hierarchy.