8000 fix!: rename `blocklyToolboxContents` to `blocklyToolboxCategoryGroup` by ruthwikchikoti · Pull Request #8384 · google/blockly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix!: rename blocklyToolboxContents to blocklyToolboxCategoryGroup #8384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix!: rename blocklyToolboxContents to blocklyToolboxCategoryGroup #8384

merged 1 commit into from
Jul 17, 2024

Conversation

ruthwikchikoti
Copy link
Contributor

The basics

The details

Resolves

Fixes #8344

Proposed Changes

This Pull Request renames the blocklyToolboxContents CSS class to blocklyToolboxCategoryGroup. All references to the old class name have been updated accordingly.

@ruthwikchikoti ruthwikchikoti requested a review from a team as a code owner July 16, 2024 18:52
@google-cla Google CLA
Copy link
google-cla bot commented Jul 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for rachel-fenichel July 16, 2024 20:02
@BeksOmega
Copy link
Collaborator

Hiya! You still need to sign the CLA and drop the extra commits like I mentioned in the other PR =)

Here are the steps to drop the commits:

  1. Fetch the latest changes from rc/v12.0.0:

    git fetch upstream rc/v12.0.0

  2. Checkout your branch:

    git checkout [your-branch-name]

  3. Start an interactive rebase:

    git rebase -i upstream/rc/v12.0.0

  4. In the editor that opens, identify the commits that aren't yours. These are likely the ones at the top of the list.

  5. Change the word pick to drop for each commit you want to remove.

  6. Save and close the editor.

  7. Force push your changes to your branch: Note that force pushing is a dangerous operation because it overwrites commit history, so if you dropped the wrong commits you could lose work.

    git push -f origin [your-branch-name]

Once you've done this, the PR should only contain your commits.

Let me know if you have any questions or run into any issues!

@ruthwikchikoti
Copy link
Contributor Author

@BeksOmega have you reviewed ?!

@BeksOmega
Copy link
Collaborator

@BeksOmega have you reviewed ?!

@ruthwikchikoti You didn't do the things I asked you to do yet. Once you make the requested changes I can review =)

@BeksOmega
Copy link
Collaborator

@ruthwikchikoti Have you seen the previous comment I left on this PR?

@ruthwikchikoti
Copy link
Contributor Author

@BeksOmega thanks completed please review !!!!

BeksOmega
BeksOmega approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator
@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the back and forth =) Once this passes CI I'll get it merged.

@BeksOmega BeksOmega changed the title #issue8344 fix!: rename blocklyToolboxContents to blocklyToolboxCategoryGroup Jul 17, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Jul 17, 2024
@BeksOmega BeksOmega merged commit e1753ae into google:rc/v12.0.0 Jul 17, 2024
8 checks passed
@BeksOmega BeksOmega mentioned this pull request Jul 17, 2024
Closed
mikeharv added a commit to code-dot-org/code-dot-org that referenced this pull request Apr 2, 2025
@mikeharv
rename toolbox class
6d791dd 
relates to google/blockly#8384
@mikeharv mikeharv mentioned this pull request Apr 3, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruthwikchikoti @BeksOmega @rachel-fenichel
0