fix: disposing workspace comments. #7264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7177
Proposed Changes
Makes it the sole responsibility of the WorkspaceComment superclass to mark the comment as disposed, instead of letting the subclass mark it as disposed before the superclass has a chance to handle disposing it.
Behavior Before Change
The superclass's dispose method did not actually run, and the comment would not be completely disposed.
Behavior After Change
Deleting a comment now fully disposes it.
Test Coverage
Previously there was test coverage for disposing WorkspaceComment, but not for disposing WorkspaceCommentSvg. I added a method testing the latter.